Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgpu: update to v24.0.0.2 #4853

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

wgpu: update to v24.0.0.2 #4853

wants to merge 10 commits into from
+1,833 −1,343

Conversation

laytan
Copy link
Collaborator

@laytan laytan commented Feb 17, 2025 •
edited
Loading

Lots of changes to webgpu here.

I did not implement futures in JS, neither did wgpu-native in native, so that should be fine.

https://github.com/gfx-rs/wgpu-native/releases/tag/v24.0.0.2

@laytan laytan changed the title wgpu: update to v24.0.0 wgpu: update to v24.0.0.1 Feb 24, 2025
@laytan laytan marked this pull request as ready for review February 24, 2025 19:53
@jimhub
Copy link

jimhub commented Feb 25, 2025

One quick note from testing this out. It looks like UncapturedErrorCallbackInfo should not have the callback mode field: https://github.com/webgpu-native/webgpu-headers/blob/bac520839ff5ed2e2b648ed540bd9ec45edbccbc/webgpu.h#L1366-L1371

@pietrovismara
Copy link

It seems that for this to work on windows you need to import system:propsys.lib and system:runtimeobject.lib here , otherwise odin build will fail with a bunch of LNK2019 errors.

@Valakor Valakor mentioned this pull request Feb 27, 2025
Draft
@laytan
Copy link
Collaborator Author

laytan commented Feb 27, 2025

One quick note from testing this out. It looks like UncapturedErrorCallbackInfo should not have the callback mode field: https://github.com/webgpu-native/webgpu-headers/blob/bac520839ff5ed2e2b648ed540bd9ec45edbccbc/webgpu.h#L1366-L1371

@jimhub Thanks! I've fixed it.

@laytan
Copy link
Collaborator Author

laytan commented Feb 27, 2025

It seems that for this to work on windows you need to import system:propsys.lib and system:runtimeobject.lib here , otherwise odin build will fail with a bunch of LNK2019 errors.

@pietrovismara Thanks! I've included the extra libraries.

@laytan laytan mentioned this pull request Feb 27, 2025
Draft
4 tasks
@laytan laytan changed the title wgpu: update to v24.0.0.1 wgpu: update to v24.0.0.2 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laytan @jimhub @pietrovismara